Skip to content

fix promotions behavior and texts - #82

Merged
nicholas-maestrello merged 3 commits into
masterfrom
B2BTEAM-3104
Jan 22, 2026
Merged

fix promotions behavior and texts#82
nicholas-maestrello merged 3 commits into
masterfrom
B2BTEAM-3104

Conversation

@nicholas-maestrello

@nicholas-maestrello nicholas-maestrello commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

What problem is this solving?

Fixes critical edge cases in quote creation and improves UI readability:

  • Promotional prices were not being preserved when creating quotes
  • Items with $0.00 promotional price were excluded from quotes
  • Large currency values (>$9,999.99) were truncated in Total and Quoted Price columns
  • "U. Mult." label was too abbreviated to read easily

How to test it?

  1. Test promotional price preservation:

    • Add items to cart with a promotion (e.g., 3 items at $10.00 and 1 item at $6.70)
    • Create a quote
    • Verify promotional prices are saved correctly in both Original Price and Quoted Price columns
  2. Test $0.00 promotional price:

    • Apply a 100% discount promotion to an item
    • Create a quote
    • Verify item is included in the quote with $0.00 price
  3. Test large currency values:

    • Add items with quantities resulting in totals >$9,999.99
    • Verify Total and Quoted Price columns display full values without truncation
  4. Test column labels:

    • Check that "Unit Multiplier" label is fully visible in EN/ES/PT

Screenshots or example usage:

Screen.Recording.2026-01-16.at.13.14.34.mov
Screenshot 2026-01-16 at 13 30 34

Related to / Depends on

Edge case reported in production with promotional pricing

@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jan 16, 2026

Copy link
Copy Markdown

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

vtex-io-docs-bot Bot commented Jan 16, 2026

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@github-actions

github-actions Bot commented Jan 16, 2026

Copy link
Copy Markdown
Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 34, PR deletions = 13

Generated by 🚫 dangerJS against f6a6a3e

Comment thread CHANGELOG.md Outdated

### Changed

- Updated "U. Mult." label to "Multiplicador de Unidade" (PT), "Unit Multiplier" (EN), and "Multiplicador de Unidad" (ES) for better readability

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isso aqui foi alinhado com o time de localization

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ataideverton Vou alinhar com eles. Vou separar em outro PR tambem para simplificar.

Comment thread react/components/QuoteDetails/QuoteTable.css Outdated
Comment thread react/utils/helpers.ts Outdated
listPrice: item.listPrice * 100,
price: item.price * 100,
sellingPrice: item.price * 100,
sellingPrice: item.sellingPrice * 100,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não tem chance do selling price vir null?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vou conferir

@nicholas-maestrello
nicholas-maestrello merged commit abc2fca into master Jan 22, 2026
14 of 15 checks passed
@nicholas-maestrello
nicholas-maestrello deleted the B2BTEAM-3104 branch January 22, 2026 11:54
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jan 22, 2026

Copy link
Copy Markdown

Your PR has been merged! App is being published. 🚀
Version 3.0.4 → 3.0.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.b2b-quotes@3.0.5

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants